Skip to content

Conversation

@BourotBenjamin
Copy link

OneSky API export YML files as "complex yaml" when there's more than one deepness level.
Symfony has it's own YAML implementation that does not accept complex YAML

As PHP has an yml extension which understand complex YAML and can load it as a PHP array, my solution is to load our files with PHP parser and to export it with Symfony's yaml parser.

As understanding complex YAML files is a new feature, I doubt that SensioLab would update their old versions (even maintained versions), so I think the better version is to handle the problem with this bundle as it is the one woe makes a bridge between those two formats

Also, I think test wouldn't appreciate this modification as they wouldn't have yaml extension, but there is multiple composer pull requests to handle pecl extensions, but none seems to have been merged.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 99.174% when pulling 299fcc0 on BourotBenjamin:YamlBridgeToSFYaml into 3b33b03 on OpenClassrooms:master.

@coveralls
Copy link

coveralls commented Nov 21, 2016

Coverage Status

Coverage decreased (-0.7%) to 99.263% when pulling a0c7230 on BourotBenjamin:YamlBridgeToSFYaml into 3b33b03 on OpenClassrooms:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants